Page MenuHomePhabricator

only one blacklist file is parsed by SpamBlacklist extension
Closed, ResolvedPublic

Description

I have tried putting entries in the local_blacklist file and the SpamBlacklist
page in my wiki both with and without pre tags wrapped around the list;
backslashes escaping dots in the URLs, etc, and it just doesn't work no matter
what - the wikimedia_blacklist is the only one that gets parsed. Neither entries
in the local_blacklist file nor in the SpamBlacklist page in the wiki itself are
actually blacklisted in practice, although - interestingly - if you screw up the
database name in the one pointing to the wiki page you WILL get script errors
whenever you try to post new edits. So I'm not quite sure where the bug is, but
I'd REALLY like to see it get fixed, so that I could maintain a local blacklist
that wouldn't get wiped out any time I fetched a new copy of mediawiki's own
blacklist.


Version: unspecified
Severity: normal

Details

Reference
bz2598

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 8:37 PM
bzimport set Reference to bz2598.
bzimport added a subscriber: Unknown Object (MLST).

Note - this might be not be an issue of the extension not handling multiple
files. I have successfully had it work with a couple smaller files. It could
be that the total KB of the combined files gets too large. Just a theory

rick.denatale wrote:

Which order do you have the files listed? I found that putting the mediawiki
file last worked for me.
For some reason the extension didn't go past it.

This was true for both files and my local Spamblacklist article in the DB.

I do notice that the downloaded mediawiki spam blacklist file doesn't seem to
end with a newline, perhaps this is the problem?!?

(In reply to comment #2)

Which order do you have the files listed? I found that putting the mediawiki
file last worked for me.

I have tried all orders, and while it seems to have weird effects, based on the
ordering, it's not consistent. I also decided to combined all 3 blacklists into
a single file, and just use that one file in the local settings, and that didn't
work either. This is why i'm wondering if it's a problem with the size of the
combined file(s)

I do notice that the downloaded mediawiki spam blacklist file doesn't seem to
end with a newline, perhaps this is the problem?!?

I tried adding a new line, as i was wondering about that also, and that didn't
have any affect.

zigger wrote:

Is this a duplicate of bug 1673?

(In reply to comment #4)

Is this a duplicate of bug 1673?

It's possible. However, the proposed patch is out-of-date, so can someone
re-apply the patch to the new code, so that we can test it out?

mm-bugs wrote:

Use array_merge instead of += operator to merge wordlists.

I think it works. Let me post an updated patch...

Attached:

  • This bug has been marked as a duplicate of 1673 ***