Page MenuHomePhabricator

OS-detection in EasyTimeline.pl fails on Mac OS X
Closed, ResolvedPublic

Description

Author: z9z8z-wps

Description:
In EasyTimeline.pl the line

if ($OS =~ /win/i)

in sub SetImageFormat matches "darwin", which is returned by OS X, assigning it Windows $fmt and $pathseparator but it should be the Linux
ones.

(Looking closer at the following lines it appears that $pathseparator doesn't get set at all if there's no OS detected)


Version: unspecified
Severity: normal
OS: Mac OS X 10.3
Platform: Macintosh

Details

Reference
bz1820

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 8:16 PM
bzimport added a project: EasyTimeline.
bzimport set Reference to bz1820.
bzimport added a subscriber: Unknown Object (MLST).

jeluf wrote:

Fixed in CVS HEAD, revision 1.13

$pathseparator is always set, because the else branch is always executed when
the if-condition doesn't match.

z9z8z-wps wrote:

Sorry that was my fault about the pathseparator. The issue is still:

In EasyTimeline.pl the line

if ($OS =~ /win/i)

in sub SetImageFormat matches "darwin", which is returned by OS X, assigning it Windows $fmt and $pathseparator but it should be the Linux
ones.

jeluf wrote:

Bug has been fixed in CVS. See
http://cvs.sourceforge.net/viewcvs.py/wikipedia/extensions/timeline/EasyTimeline.pl?r1=1.12&r2=1.13
Please reopen if you have checked the new version and problem still exists.