Page MenuHomePhabricator

Show a small PDF.png icon for files of filetype PDF (at least for media: links to uploaded files which filetypes has been checked to be PDF)
Closed, ResolvedPublic

Description

I propose to show in general a small *pdf icon* for such links pointing to a
PDF file. This would be similar to small icon external.png, which is already
shown after every _external_ link. It could be handled in monobook.css.

For security reasons, the icon could probably be shown only for media: links to
uploaded files which filetypes has been checked to be PDF during or after the
upload.

Tom


Hendrik wrote:

How do you want to detect whether an URL points to a PDF-file (i. e. not

something that Internet

Explorer would executeable but is called "something.pdf")
Hendrik

Hendrik,

as the subject says: I only propose to show an icon, I did not propose to scan
file types of something extern. If that file is internal i.e. linked via the
[[media:filename.pdf]] notation, then the server has potentially the chance to
check the "magic" byte of that file; if it is external, i.e.
[http://server/filename.pdf|othername], you can only argue from the filename.pdf
that it pretends to be "PDF" . If you see a security problem, what does the
(PDF.png vs. external.png ?) icon change in this respect ? Nothing;

but with my proposal you could even have *two* different PDF icons, a green
"secure" icon for internal (filetype scanned) [[media:filename.pdf]] files and a
red "insecure" alerting one ("extern; probably PDF") for the others. This is
just meant as an ad-hoc proposal to show you the positive possibilities of my
proposal.

Does my answer satisfy you ?

Tom


Version: 1.5.x
Severity: enhancement

Details

Reference
bz1311
TitleReferenceAuthorSource BranchDest Branch
CI, do some image updates in groupsrepos/releng/cli!342addshoreimage-update-groupsmain
Customize query in GitLab

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 8:11 PM
bzimport added a project: MediaWiki-Parser.
bzimport set Reference to bz1311.
bzimport added a subscriber: Unknown Object (MLST).

zigger wrote:

*** This bug has been marked as a duplicate of 1578 ***