Page MenuHomePhabricator

Links in headings not shown in TOC
Closed, ResolvedPublic

Description

See URL - links aren't shown in the TOC. This must be a post-1.3 regression,
works fine on live site.


Version: 1.4.x
Severity: normal
OS: Linux
Platform: PC
URL: http://test.wikipedia.org/wiki/Poo

Details

Reference
bz206

Related Objects

StatusSubtypeAssignedTask
ResolvedNone
ResolvedNone

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 6:42 PM
bzimport added a project: MediaWiki-Parser.
bzimport set Reference to bz206.
bzimport added a subscriber: Unknown Object (MLST).

mrwojo wrote:

In internalParse():

  • replaceInternalLinks() calls makeLinkObj(), which converts bracketed link text

into "<!--LINK ..." format

  • formatHeadings() removes HTML from toclines (removing those "<!--LINK "s)

jeluf wrote:

Should formatHeadings be done after resolving the links?
Alternatively, formatHeadings has to become <!--LINK aware.

jeluf wrote:

Fixed in Parser.php, rev 1.253